[vlc-devel] [PATCH] compat: work-around busted FreeBSD qsort_r()
epirat07 at gmail.com
Thu Nov 29 18:18:34 CET 2018
On 29 Nov 2018, at 18:11, Rémi Denis-Courmont wrote:
> Le torstaina 29. marraskuuta 2018, 18.49.12 EET Marvin Scholz a écrit :
>> On 29 Nov 2018, at 17:17, Rémi Denis-Courmont wrote:
>>> Thanks for the review. As I cannot test it (or cannot be bothered to
>>> install a FreeBSD VM), I have no plans to update the patch myself
>> Ok, understandable. I will try to come up with a solution.
>> Currently the only good approach I can see is to give the compat
>> a different name, like vlc_qsort_r and if the system provides a
>> qsort_r then just `#define vlc_qsort_r qsort_r` instead of compiling the
>> compat one.
>> Any objections and/or better ideas how to do this?
> Yes objection. AC_REPLACE_FUNCS simply does not work that way.
Can't it be checked with AC_CHECK_FUNC and then if missing or
broken be added with AC_LIBOBJ, instead of using AC_REPLACE_FUNCS?
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel