[vlc-devel] [PATCH] compat: work-around busted FreeBSD qsort_r()

[Marvin Scholz]

On 29 Nov 2018, at 18:11, Rémi Denis-Courmont wrote:

> Le torstaina 29. marraskuuta 2018, 18.49.12 EET Marvin Scholz a écrit :
>> On 29 Nov 2018, at 17:17, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> Thanks for the review. As I cannot test it (or cannot be bothered to
>>> install a FreeBSD VM), I have no plans to update the patch myself
>>> though.
>>
>> Ok, understandable. I will try to come up with a solution.
>>
>> Currently the only good approach I can see is to give the compat
>> function
>> a different name, like vlc_qsort_r and if the system provides a
>> non-broken
>> qsort_r then just `#define vlc_qsort_r qsort_r` instead of compiling the
>> compat one.
>>
>> Any objections and/or better ideas how to do this?
>
> Yes objection. AC_REPLACE_FUNCS simply does not work that way.

Can't it be checked with AC_CHECK_FUNC and then if missing or
broken be added with AC_LIBOBJ, instead of using AC_REPLACE_FUNCS?

>
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel