[vlc-devel] [PATCH] libvlc: configure cork on startup

[Thomas Guillem]

On Thu, Nov 29, 2018, at 14:08, Rémi Denis-Courmont wrote:
> I don't follow the causal link here. This code does not make
> sense to me.
Could you elaborate please ? I don't get the problem.
This patch is  straight forward, it just forward the cork setting to
the player.
> 
> Le 28 novembre 2018 16:08:15 GMT+02:00, Victorien Le Couviour--Tuffet
> <victorien.lecouviour.tuffet at gmail.com> a écrit :>> Since the player now handles the playlist cork option, we need to
>>>> configure it from this variable at the beginning. src/libvlc.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>> 
>> 
>> 
>> diff --git a/src/libvlc.c b/src/libvlc.c
>> 
>> index 2f8ded692e..f5d6382cfd 100644
>> 
>> --- a/src/libvlc.c
>> 
>> +++ b/src/libvlc.c
>> 
>> @@ -135,6 +135,7 @@ PlaylistConfigureFromVariables(vlc_playlist_t
>> *playlist, vlc_object_t *obj)
>>>>          media_stopped_action = VLC_PLAYER_MEDIA_STOPPED_CONTINUE;
>>>>  
>> 
>>      bool start_paused = var_InheritBool(obj, "start-paused");
>> 
>> +    bool playlist_cork = var_InheritBool(obj, "playlist-cork");
>>>>  
>> 
>>      vlc_playlist_Lock(playlist);
>> 
>>      vlc_playlist_SetPlaybackOrder(playlist, order);
>> 
>> @@ -146,6 +147,7 @@ PlaylistConfigureFromVariables(vlc_playlist_t
>> *playlist, vlc_object_t *obj)
>>>>       * implementation detail */
>> 
>>      vlc_player_SetMediaStoppedAction(player, media_stopped_action);
>>>>      vlc_player_SetStartPaused(player, start_paused);
>> 
>> +    vlc_player_SetPauseOnCork(player, playlist_cork);
>> 
>>  
>> 
>>      vlc_playlist_Unlock(playlist);
>> 
>>  }
>> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
> excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181130/f91278a7/attachment.html>