[vlc-devel] [PATCH] chromecast: detect additional failed load type

Thomas Guillem thomas at gllm.fr
Mon Oct 1 17:57:51 CEST 2018


You can resend them.

On Mon, Oct 1, 2018, at 17:54, Erick Tyndall wrote:
> My apologies, there was an issue with my configuration. It has been
> corrected now. Do I resend the patch to the mailing list or is there
> something else I should do?
> On Mon, Oct 1, 2018 at 5:59 AM Thomas Guillem <thomas at gllm.fr> wrote:
> >
> > This patch doesn't apply, the processMediaMessage line is truncated. Did you send this patch with git send-email ?
> > You can send me a github/gitlab/anything branch if you want.
> >
> >
> > On Sat, Sep 29, 2018, at 04:25, Erick Tyndall wrote:
> > > Correctly handle an additional failed load type. Specifically x265
> > > codec on chromecast version 1 and 2 cause an idle state with an
> > > unhandled error.
> > >
> > > ***This patch supersedes "cast: force transcoding of x265 videos".
> > > ---
> > >  modules/stream_out/chromecast/chromecast_ctrl.cpp | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> > > b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> > > index 4c08f8b57a..a2c68e682a 100644
> > > --- a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> > > +++ b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> > > @@ -856,6 +856,8 @@ void intf_sys_t::processMediaMessage( const
> > > castchannel::CastMessage& msg )
> > >                      // Do not reset the mediaSessionId to ensure we refuse all
> > >                      // other MEDIA_STATUS from the new session.
> > >                  }
> > > +                else if ( idleReason == "ERROR" && m_state == Playing )
> > > +                    setState( LoadFailed );
> > >                  else if ( m_state == Buffering )
> > >                      setState( LoadFailed );
> > >                  else
> > > --
> > > 2.17.1
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list