[vlc-devel] [PATCH] chromecast: resize large resolution videos

[Thomas Guillem]

Finally, I'm not sure I understand this patch. When looking at transcode_encoder_video_configure() in modules/stream_out/transcode/encoder/video.c I see that the encoder fmt_out is scaled to the maxwidth/maxheight. So this should be enough. Why adding this width parameter then?

On Mon, Oct 1, 2018, at 18:33, Erick Tyndall wrote:
> From: erythros <erythros at gmail.com>
> 
> 1080p and lower resolution videos correctly scale/resize during 
> transcoding. This patch corrects the resizing of videos that exceed 
> 1080p.
> ---
>  modules/stream_out/chromecast/cast.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/stream_out/chromecast/cast.cpp b/modules/
> stream_out/chromecast/cast.cpp
> index 2ef26d8eb4..3de2d7a3ba 100644
> --- a/modules/stream_out/chromecast/cast.cpp
> +++ b/modules/stream_out/chromecast/cast.cpp
> @@ -1133,10 +1133,10 @@ 
> sout_stream_sys_t::GetVcodecOption( sout_stream_t *p_stream, 
> vlc_fourcc_t *p_cod
>      {
>          case CONVERSION_QUALITY_HIGH:
>          case CONVERSION_QUALITY_MEDIUM:
> -            ssout << video_maxres_hd << ',';
> +            ssout << ( ( p_vid->i_width > 1920 ) ? "width=1920," : "" ) 
> << video_maxres_hd << ',';
>              break;
>          default:
> -            ssout << video_maxres_720p << ',';
> +            ssout << ( ( p_vid->i_width > 1280 ) ? "width=1280," : "" ) 
> << video_maxres_720p << ',';
>      }
>  
>      if( p_vid == NULL
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel