[vlc-devel] [PATCH 3/7] opengl: factor libplacebo helpers out to their own file

[Thomas Guillem]

On Tue, Oct 2, 2018, at 15:50, Hugo Beauzée-Luyssen wrote:
> On Mon, Oct 1, 2018, at 4:51 PM, Niklas Haas wrote:
> > From: Niklas Haas <git at haasn.xyz>
> > 
> > This is in preparation for a new vout based on libplacebo, for which
> > reusing these shared helpers with OpenGL will make sense.
> > 
> > Apart from moving stuff around, this commit only has minor changes
> > (changed define names in some places, minor rewording of some options).
> > ---
> >  modules/video_output/Makefile.am              |   1 +
> >  .../video_output/opengl/fragment_shaders.c    |  54 +-----
> >  modules/video_output/opengl/vout_helper.c     |  23 +--
> >  modules/video_output/opengl/vout_helper.h     | 144 +-------------
> >  modules/video_output/placebo_utils.c          | 102 ++++++++++
> >  modules/video_output/placebo_utils.h          | 178 ++++++++++++++++++
> 
> Shouldn't placebo_utils be added to POTFILES.in as well?

Hum, I would prefer to remove translations for that kind of settings.
How do you ensure that "Tone-mapping desaturation coefficient" or "Highlight clipped pixels" are correctly translated ?
"Coefficient de la table des tons" and "Surlignage des pixels coupés" ? 

> 
> Regards,
> 
> -- 
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel