[vlc-devel] [PATCH] contrib: don't use ln -s on Windows

Steve Lhomme robux4 at ycbcr.xyz
Wed Oct 3 16:53:44 CEST 2018


It will fail.

"ln -s" is usually replaced by "cp -R" with autotools
---
 contrib/src/main.mak     | 4 ++++
 contrib/src/qt/rules.mak | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/contrib/src/main.mak b/contrib/src/main.mak
index ddd8b16aaaf..c21d7665c94 100644
--- a/contrib/src/main.mak
+++ b/contrib/src/main.mak
@@ -136,10 +136,14 @@ endif
 EXTRA_CFLAGS += $(CFLAGS)
 endif
 
+LN_S = ln -s
 ifdef HAVE_WIN32
 ifneq ($(shell $(CC) $(CFLAGS) -E -dM -include _mingw.h - < /dev/null | grep -E __MINGW64_VERSION_MAJOR),)
 HAVE_MINGW_W64 := 1
 endif
+ifndef HAVE_CROSS_COMPILE
+LN_S = cp -R
+endif
 ifneq ($(findstring clang, $(shell $(CC) --version)),)
 HAVE_CLANG := 1
 endif
diff --git a/contrib/src/qt/rules.mak b/contrib/src/qt/rules.mak
index eb2b406d888..04e8031afb1 100644
--- a/contrib/src/qt/rules.mak
+++ b/contrib/src/qt/rules.mak
@@ -90,7 +90,7 @@ ifdef HAVE_WIN32
 endif
 ifdef HAVE_CROSS_COMPILE
 	# Building Qt build tools for Xcompilation
-	cd $</include/QtCore; ln -sf $(QT_VERSION)/QtCore/private
+	cd $</include/QtCore; $(LN_S)f $(QT_VERSION)/QtCore/private private
 	cd $<; $(MAKE) -C qmake
 	cd $<; $(MAKE) sub-qmake-qmake-aux-pro-install_subtargets install_mkspecs
 	cd $</src/tools; \
-- 
2.17.1



More information about the vlc-devel mailing list