[vlc-devel] [PATCH 1/2] contribs: pthreads: also build the CRT headers
robux4 at ycbcr.xyz
Fri Oct 5 10:31:52 CEST 2018
On 04/10/2018 15:15, Martin Storsjö wrote:
> On Thu, 4 Oct 2018, Steve Lhomme wrote:
>> contrib/src/pthreads/rules.mak | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/contrib/src/pthreads/rules.mak
>> index b7d2b57681e..9d762466286 100644
>> --- a/contrib/src/pthreads/rules.mak
>> +++ b/contrib/src/pthreads/rules.mak
>> @@ -18,6 +18,8 @@ pthreads: mingw-w64-v$(WINPTHREADS_VERSION).tar.bz2
>> .pthreads: pthreads
>> + cd $</mingw-w64-headers && $(HOSTVARS) ./configure $(HOSTCONF)
>> + cd $< && $(MAKE) -C mingw-w64-headers
>> cd $</mingw-w64-libraries/winpthreads && $(HOSTVARS) ./configure
>> cd $< && $(MAKE) -C mingw-w64-libraries -C winpthreads install
>> touch $@
> Please no, this isn't the right solution for the issue we're discussion.
> For cases where the mingw-w64 headers and import libraries use a
> different default msvcrt (ucrtbsae), this will override that and break
> everything. The mingw-w64 headers and import libraries should really
> come from the same version, otherwise many things will break.
OK, I copied the include/ into x86_64-w64-mingw32/include/ for now.
There's never going to be symbolic link on Windows/msys so that's
probably the way to go anyway.
> // Martin
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel