[vlc-devel] [PATCH 01/12] input item: expose locked version of GetMeta()

[Thomas Guillem]

On Fri, Oct 12, 2018, at 21:44, Rémi Denis-Courmont wrote:
> Le perjantaina 12. lokakuuta 2018, 0.14.39 EEST Romain Vimont a écrit :
> > In order to sort the playlist correctly, the input items must be locked
> > across several calls to GetMeta() (among others).
> 
> Taking multiple locks from the same class simultaneously is a terrible idea 
> that will defeat lock dependency checkers (no that we use any, but we probably 
> should).
> 
> And it is theoretically only possible if there is an order, which this patch 
> suspiciously fails to define.

Indeed, the playlist test fails in the _Sort() test with tsan:  "lock-order-inversion".

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel