[vlc-devel] [PATCH 3/3] access/udp: reduce mtu amount on initial packets

[Francois Cartegnie]

Le 16/10/2018 à 14:46, Ilkka Ollakka a écrit :
> On Mon, Oct 15, 2018 at 10:40:14PM +0200, Francois Cartegnie wrote:
>> Le 15/10/2018 à 20:30, Ilkka Ollakka a écrit :
>>> In this approach, mtu is setted to high on start, and if received data
>>> is less than 1500 and mtu is higher than that, we adjust mtu on future
>>> packets to be smaller. In majority of cases in UDP streaming, packet
>>> size is usually quite constant, so it should work, even if it's not
>>> generic solution to udp packet receiving.
>> That can't work on a single packet.
>>
>> H264 RTP treaming usually sees packets for PPS, SPS, and the remainder
>> of frames being < MTU.
> 
> Would you happen to have tcpdump capture of such case?
> 

You don't need. Your patch just should not rely on a single packet, or
we'll get a randomly reproducible and unfixed bug.

-- 
Francois Cartegnie
VideoLAN - VLC Developer