[vlc-devel] [PATCH] medialibrary: fix vlc_tick_t set on a value that should be in milliseconds

[Hugo Beauzée-Luyssen]

On Thu, Oct 18, 2018, at 4:30 PM, Steve Lhomme wrote:
> At least that's what the doc of setDuration() claims.
> ---
>  modules/misc/medialibrary/MetadataExtractor.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/misc/medialibrary/MetadataExtractor.cpp b/modules/
> misc/medialibrary/MetadataExtractor.cpp
> index c7a5edf95bd..7440bd4db36 100644
> --- a/modules/misc/medialibrary/MetadataExtractor.cpp
> +++ b/modules/misc/medialibrary/MetadataExtractor.cpp
> @@ -89,7 +89,7 @@ void 
> MetadataExtractor::populateItem( medialibrary::parser::IItem& item, 
> input_i
>                  emptyStringWrapper( vlc_meta_Get( inputItem->p_meta, 
> pair.second ) ) );
>      }
>  
> -    item.setDuration( inputItem->i_duration );
> +    item.setDuration( MS_FROM_VLC_TICK(inputItem->i_duration) );
>  
>      for ( auto i = 0; i < inputItem->i_es; ++i )
>      {

LGTM, but you probably should update the input_item_t::i_duration doc while you're at it :)

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr