[vlc-devel] [PATCH] Input and Output modules for the Reliable Internet Stream Transport (RIST) Protocol.

[Jean-Baptiste Kempf]

No remarks anymore from my side, besides some lines who are waaaaay above 80 col and some msg_Info that should be msg_Dbg.

On Wed, 24 Oct 2018, at 10:17, Sergio M. Ammirata wrote:
> Input module with all the mentioned changes. I ended up using strlcpy 
> and not strncpy like I mentioned in my previous email.
> 
> -----Original Message-----
> From: Jean-Baptiste Kempf [mailto:jb at videolan.org] 
> Sent: Sunday, October 21, 2018 8:43 PM
> To: Sergio M. Ammirata; vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH] Input and Output modules for the 
> Reliable Internet Stream Transport (RIST) Protocol.
> 
> 
> On Sun, 21 Oct 2018, at 16:57, Sergio M. Ammirata wrote:
> > All issues are fixed, here is in the revised input module patch.
> 
> So:
> - missing NEWS, po/POTFILES.in, modules/MODULE_LIST entries
> - you must surround the poll.h include with HAVE_POLL
> - use str*cpy instead of strcpy
> 
> Also, you have many options in this module. Are they all necessary?
> 
> best,
> 
> 
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> Email had 1 attachment:
> + 0001-Input-module-for-the-Reliable-Internet-Stream-Transp.patch
>   51k (text/plain)


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734