[vlc-devel] [PATCH 1/2] access/udp: use MSG_PEEK for non-linux cases to check new size

Ilkka Ollakka ileoo at videolan.org
Fri Oct 26 18:31:26 CEST 2018

On Fri, Oct 26, 2018 at 07:24:37PM +0300, Rémi Denis-Courmont wrote:
> Le vendredi 26 octobre 2018, 19:15:10 EEST Ilkka Ollakka a écrit :
> > ---
> >  modules/access/udp.c | 36 ++++++++++++++++++++++++++++--------
> >  1 file changed, 28 insertions(+), 8 deletions(-)


> I doubt that allocating 64 KiB on the stack is a good idea.

Most likely true, I'll change that

> And this is essentially worse performance-wise than copying memory.

Most likely yes, reasoning behind this approach is, that MSG_TRUNC
shouldn't happen more than few times per stream receiving/change. So we
can keep good performance on normal case and accept that rare case
doesn't need to be optimized for high packet per second performance.

Ilkka Ollakka
The best portion of a good man's life, his little, nameless, unremembered acts
of kindness and love.
		-- Wordsworth
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181026/a4531895/attachment.sig>

More information about the vlc-devel mailing list