[vlc-devel] [PATCH 1/2] video_output: no need to release the subpic early

Steve Lhomme robux4 at ycbcr.xyz
Sat Oct 27 08:37:11 CEST 2018


The whole point was to set it to NULL so it's not passed to Display() but it's
not passed anymore.
---
 src/video_output/video_output.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index cc95c4d874..52e8db031f 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -1204,12 +1204,6 @@ static int ThreadDisplayRenderPicture(vout_thread_t *vout, bool is_forced)
             picture_BlendSubpicture(todisplay, sys->spu_blend, subpic);
         vout_display_Prepare(vd, todisplay, do_dr_spu ? subpic : NULL,
                              todisplay->date);
-
-        if (!do_dr_spu && subpic)
-        {
-            subpicture_Delete(subpic);
-            subpic = NULL;
-        }
     }
 
     vout_chrono_Stop(&sys->render);
-- 
2.17.0



More information about the vlc-devel mailing list