[vlc-devel] [PATCH 4/4] codec: add a dav1d AV1 decoder module

Francois Cartegnie fcvlcdev at free.fr
Sun Oct 28 09:15:09 CET 2018

Le 28/10/2018 à 08:10, Steve Lhomme a écrit :
> diff --git a/modules/codec/dav1d.c b/modules/codec/dav1d.c
> +typedef struct
> +{
> +    Dav1dSettings s;
> +    Dav1dContext *c;
> +    timestamp_fifo_t *ts_fifo;
> +} decoder_sys_t;

You can't use fifo with that kind of API.

There's no guarantee on frame order,
you can't handle frame drops.

You don't also have any callback for freeing private structs on dropped
frame. That's why a ring buffer with static ID bound to frame priv is
used on other decoders.

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list