[vlc-devel] [RFC 1/1] vlc_vector: add helpers for vectors

[Rémi Denis-Courmont]

Le lundi 3 septembre 2018, 11:20:41 EEST Steve Lhomme a écrit :
> On 31/08/2018 17:43, Rémi Denis-Courmont wrote:
> > Le torstaina 30. elokuuta 2018, 17.29.14 EEST Romain Vimont a écrit :
> >>> I think Rémi meant separate commit for implementation and test.
> >> 
> >> Ah ok! Sorry, I didn't get it.
> >> 
> >> However, I thought it was a good practice to include tests in the same
> >> commit as the implementation.
> > 
> > It is certainly commendable practice to include tests in the same push as
> > implementation.
> > 
> > I don't see the point putting them in the same commit, so long as
> > incremental build is not broken. The smaller the commits, the better.
> 
> On the other hand if we revert the implementation commit, building the
> tests is broken.

On the other hand, if we have to revert the broken test and not the 
implementation...

And if you revert the implementation, you have to revert all the users, so it 
will be a mess regardless.

-- 
Rémi Denis-Courmont