[vlc-devel] [PATCH 1/2] input: refactor Control for the next commit

[Rémi Denis-Courmont]

Sorry, I don't follow at all now.

Le 4 septembre 2018 15:47:59 GMT+08:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Mon, Sep 3, 2018, at 18:11, Rémi Denis-Courmont wrote:
>> Le lundi 3 septembre 2018, 18:56:57 EEST Thomas Guillem a écrit :
>> > ---
>> >  src/input/input.c | 52
>++++++++++++++++++++++++++---------------------
>> >  1 file changed, 29 insertions(+), 23 deletions(-)
>> 
>> Adding demux_t helpers to vlc_demux.h would be more conventional  ?
>
>Does this mean the following:
> - Add 2 new controls: DEMUX_JUMP_POSITION and DEMUX_JUMP_TIME
> - Implement these controls in demux_vaControlHelper()
>- Modify all demux modules to forward this control to the helper
>demux_vaControlHelper()
>
>Cons: have to modify all modules
>
>Pros: demux modules can implement JUMP controls themselves, simpler
>input Control implementation.
>
>> 
>> -- 
>> Rémi Denis-Courmont
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180905/23d97c0b/attachment.html>