[vlc-devel] [RFC PATCH 2/2] player: signal position discontinuities

[Francois Cartegnie]

Le 06/09/2018 à 13:11, Thomas Guillem a écrit :

> +     * This callback signals a discontinuity in the player position (because of
> +     * a rate change, a pause, a seek, or a buffering).
> +     *
> +     * Example: When a discontinuity starts, the UI can show an indefinite
> +     * progress. When it stops, the UI can set the progress bar to the time/pos
> +     * value, and continue updating it according to the rate.
> +     *
> +     * @param player locked player instance
> +     * @param started true to start a discontinuity, false to end it
> +     * @param time the current time or VLC_TICK_INVALID if started is false
> +     * @param pos the current pos or VLC_TICK_INVALID if started if false
> +     * @param rate the current rate of VLC_TICK_INVALID if started if false
> +     */
> +    void (*on_discontinuity_changed)(vlc_player_t *player, bool started,
> +                                     vlc_tick_t time, float pos, float rate,
> +                                     void *data);

A discontinuity is a unique atomic event. It has no start or end. It
can't be used for such meaning, and would be confusing.

That's more likely an on_change event which combines on_random_access
and on_playback_rate_change


-- 
Francois Cartegnie
VideoLAN - VLC Developer