[vlc-devel] [PATCH 2/2] Make decklink input/output modules build on OSX

[Devin Heitmueller]

Hi j-b,

Thanks for taking the time to review.

> On Sep 6, 2018, at 4:44 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> 
> This is not the correct way, sorry:
> - either you patch the SDK when building the contribs 
> - or you add this header next to the decklink.cpp file and include with ../

I have no objection to moving the header.  I just thought using the “include” directory was the right approach given the code is shared by both the access and output modules.  I don’t think patching the Blackmagic sources is a reasonable approach given they don’t come from contrib and the headers to be used vary by platform.

> 
> Btw, some features already exist, like dup_wchar_to_utf8 that is exactly FromWide() from vlc_charset.h
> and related functions.

Ok, I’ll take a look and if the function is duplicated I will reference it directly.

Thanks,

Devin