[vlc-devel] [PATCH 2/2] Make decklink input/output modules build on OSX

[Marvin Scholz]

On 6 Sep 2018, at 22:57, Jean-Baptiste Kempf wrote:

> Ho,
>
> On Thu, 6 Sep 2018, at 22:54, Marvin Scholz wrote:
>> This is not the correct way to do this reliably
>> I would suggest you copy the implementation of CFStringCopyCString()
>> from modules/text_renderer/freetype/fonts/darwin.c instead.
>
> Which brings a good question:
> - should that CFStringCopyCString be the FromLocale() (or dup, or similar) implementation in vlc_charset.h on OSX?
>

It would be definitely good to have that function in a common place, we already duplicate this function in at least
two different modules and what this function does in probably 2 other places in slightly different ways.
(Which can lead to problems if we ever find a bug in it and then forget to fix it everywhere, like it
happened in the past)

> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180906/c38cd4cf/attachment.sig>