[vlc-devel] [RFC PATCH 2/2] player: signal position discontinuities

[Rémi Denis-Courmont]

Le vendredi 7 septembre 2018, 12:01:38 EEST Francois Cartegnie a écrit :
> Le 07/09/2018 à 10:42, Thomas Guillem a écrit :
> >> A discontinuity is a unique atomic event. It has no start or end. It
> >> can't be used for such meaning, and would be confusing.
> >> 
> >> That's more likely an on_change event which combines on_random_access
> >> and on_playback_rate_change
> > 
> > And on_buffering event ? Or on_random_access is the same.
> 
> Can we have random access without implied buffering ? (or immediate
> buffering ?)
> 
> Pause can probably be merged as rate_change.

I guess Thomas wants to distinguish clock stuff, which needs to provide a 
mapping fomr wall clock to play time, and buffer status. Both are separate 
thing from GUI point of view, and it probably makes sense to have separate 
events.

Having said that, I agree that the choice of event parameters looks 
suspicious.

-- 
Rémi Denis-Courmont