[vlc-devel] [PATCH] http access: retain auth struct for the runtime of the module

[Felix Paul Kühne]

Thanks for pointing this out. Regrettably, I missed that when writing the patch (which was merged this morning).

The problem of 9bc4991e is that while Basic Authentication works just fine, Digest Authentication will fail as all Digest information is lost on the reconnections. Therefore, certain streams will no longer play which is a regression from 2.2.

See https://code.videolan.org/videolan/VLCKit/issues/197 for a sample stream illustrating the issue.

Do you have better ideas to solve the issue?

Note that my patch deinitializes the auth state machine in two code paths, but I’m unsure whether this is fixing the leak your patch addresses or not.

Best regards,

Felix

> On 14. Sep 2018, at 15:16, Rémi Denis-Courmont <remi at remlab.net> wrote:
> 
> Revert of 9bc4991ebcb02d477bea1f75b2f6d9e90c8ee77a.
> 
> Obviously nack.
> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel