[vlc-devel] [PATCH] mux:mp4: fix 32 bits written where it should be 64

[Steve Lhomme]

I don't have the spec, but I thought that there was a mode in 32 bits 
(above in the !b_64_ext) and one (extended) in 64 bits. But maybe 
they're odd like that.


On 20/09/2018 05:28, Zhao Zhili wrote:
>
>
> On 2018年09月19日 20:37, Steve Lhomme wrote:
>> ---
>>   modules/mux/mp4/libmp4mux.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/mux/mp4/libmp4mux.c b/modules/mux/mp4/libmp4mux.c
>> index 92e7b1fe322..7d4d2fb8ad5 100644
>> --- a/modules/mux/mp4/libmp4mux.c
>> +++ b/modules/mux/mp4/libmp4mux.c
>> @@ -1600,7 +1600,7 @@ bo_t * mp4mux_GetMoovBox(vlc_object_t *p_obj, 
>> mp4mux_trackinfo_t **pp_tracks, un
>>               }
>>               bo_add_64be(mdhd, i_timestamp);   // creation time
>>               bo_add_64be(mdhd, i_timestamp);   // modification time
>> -            bo_add_32be(mdhd, p_stream->i_timescale); // timescale
>> +            bo_add_64be(mdhd, p_stream->i_timescale); // timescale
>
> ISO/IEC 14496-12:2005(E) 8.8.2 says it's unsigned int(32). Would you 
> mind share some details why it should be 64?
>
>>               bo_add_64be(mdhd, i_stream_duration * 
>> p_stream->i_timescale / i_movie_timescale);  // duration
>>           }
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel