[vlc-devel] [PATCH 3/3] linux: Add for kms vout plugin possibility to choose output display

[Juha-Pekka Heikkila]

On 20.09.2018 17:19, Filip Roséen wrote:
> Hi Thomas,
> 
> On 2018-09-17 08:27, Thomas Guillem wrote:
> 
>     |On Fri, Sep 14, 2018, at 15:37, Juha-Pekka Heikkila wrote:|
> 
>         |I'm not certain how to use change_integer_cb(). I tried
>         following module descriptor:|
> 
>     |Hello, the only way I know is from the QT UI, in advanced
>     preferences, go to your module page. Your option should be populated
>     via your ChooseConnector callback. Is there is no way to do that
>     from command line, maybe we should add one, no ?|
> 
> If you by “command line” refer to interfaces, such as 
> |modules/gui/ncurses.c| or |share/lua/intf/*|, that runs in a terminal, 
> I agree with you, but I am not sure that we would like to add support 
> for such interaction in any other places than those (and of course other 
> interface implementations).
> 
> Perhaps one could add a diagnostic for modules that support such change 
> of values, that is printed on use, stating that there are options to 
> select. Though, isn’t it already possible to get the list of entities by 
> looking at the output associated with |-H| and the module in question?
> 
> I am all for increasing the usability of the current interfaces, but 
> adding support in the core for reading from the shell where the instance 
> of vlc was spawned, if any, sounds like the wrong path to walk.
> 

Hmm.. so in these ways my original patch was mostly correct? Available 
connectors are listed among debug information when run in verbose mode 
but unless "kms-connector" parameter is given first connected is chosen 
which most often is correct behavior.

Those two patches which were not committed I'll resubmit for another 
round. I need to fix at least one "D'oh!" type issue included in them.

/Juha-Pekka