[vlc-devel] [PATCH] picture: fix missing video_format_t attributes from the picture
remi at remlab.net
Fri Sep 28 14:23:59 CEST 2018
Le vendredi 28 septembre 2018, 15:04:33 EEST Filip Roséen a écrit :
> LGTM, as long as we are sure that we will not (once again) step into
> life-time issues related to the ownership of
> `video_format_t.p_palette` (but as it worked before, well.. it at
> least wouldn't get worse than what we had previously).
I have said it before and I will say it again: we should just kill p_palette
so that video format is actually POD like so much code assumes. The troubles
are not worth the benefits. It is just daft to treat paletized formats as
decoded formats nowadays.
We should just have a common helper to dereference paletized pictures into YUV
or RGB in the few affected video decoders.
More information about the vlc-devel