[vlc-devel] [PATCH] qt: don't set the interface on top if the video will not be embedded
robux4 at ycbcr.xyz
Tue Apr 2 08:19:57 CEST 2019
On 4/1/2019 5:26 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 1. huhtikuuta 2019, 13.41.22 EEST Steve Lhomme a écrit :
>> The doc of video-on-top is:
>> Alwaysplacethevideowindowontopofotherwindows. That sounds like a feature
>> of the standalone video window rather than the UI. It corresponds to the
>> VOUT_WINDOW_STATE_ABOVE state that is already handled by many of them.
>> The UI may use the flag if a standalone window is not used. But if there
>> is one, IMO it shouldn't.
> Yes, that seems to match the documentation.
> Still, I think Qt should allow the window state, rather than second guess from
> the configuration leading to unnecessary error corner cases.
It still does after this patch but only if we know we won't use an
external window (which is coming for Windows).
More information about the vlc-devel