[vlc-devel] [vlc-commits] android: ignore unsupported zoom/fill change

[Steve Lhomme]

On 4/1/2019 7:45 PM, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Apr  1 19:51:45 2019 +0300| [522bee83dbfbeae66485cda7767489a19ed0decb] | committer: Rémi Denis-Courmont
>
> android: ignore unsupported zoom/fill change
>
> We don't want to reset the picture pool here.

That sounds like the job of the core to decide what to do in that case. 
Not the display module to pretend it handles something when in fact it 
doesn't. The core now has no way to know the actual state of the display 
module.

>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=522bee83dbfbeae66485cda7767489a19ed0decb
> ---
>
>   modules/video_output/android/display.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/modules/video_output/android/display.c b/modules/video_output/android/display.c
> index 73767fcd09..1825eb4900 100644
> --- a/modules/video_output/android/display.c
> +++ b/modules/video_output/android/display.c
> @@ -1068,8 +1068,9 @@ static int Control(vout_display_t *vd, int query, va_list args)
>           vlc_assert_unreachable();
>       default:
>           msg_Warn(vd, "Unknown request in android-display: %d", query);
> +        return VLC_EGENERIC;
>       case VOUT_DISPLAY_CHANGE_ZOOM:
>       case VOUT_DISPLAY_CHANGE_DISPLAY_FILLED:
> -        return VLC_EGENERIC;
> +        return VLC_SUCCESS;
>       }
>   }
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits