[vlc-devel] [PATCH 2/3] player: add a QT window context

[Thomas Guillem]

So we we have 3 choices:

1/ Set the qt4-iface into libvlc => Other players (VLM) will also use it = BAD
2/ Do what this patch is doing => Pollute the core, do we really care ?
3/ Make the vlc_player_t an vlc_object_t => every player client will be able to put their own hack now (like it was before)

Problem with 2/ is that we may have to add 2-3 more functions that will be needed by the libvlc_media_player. If we choose 3/, libvlc will put it own foo into the player variables.

So, which solutions do you prefer ?

On Mon, Apr 1, 2019, at 17:55, Thomas Guillem wrote:
> 
> On Mon, Apr 1, 2019, at 17:49, Rémi Denis-Courmont wrote:
> > Le maanantaina 1. huhtikuuta 2019, 18.32.44 EEST Thomas Guillem a écrit :
> > > On Mon, Apr 1, 2019, at 17:30, Rémi Denis-Courmont wrote:
> > > > Le maanantaina 1. huhtikuuta 2019, 14.21.43 EEST Thomas Guillem a écrit :
> > > > > This will be used by the future QT interface in order to store the
> > > > > legacy
> > > > > "qt4-iface" context.
> > > > 
> > > > This looks like a much worse hack than the current approach, which at
> > > > least
> > > > does not pollute the core.
> > > 
> > > So, we will store the "qt4-iface" into libvlc then.
> > 
> > That won't work properly if VLM - or whatever succeeds it - is used.
> 
> Yes that is why I did this patch.
> 
> I can expose vlc_player_t as a vlc_object_t, but I really prefer this patch.
> 
> > 
> > -- 
> > レミ・デニ-クールモン
> > http://www.remlab.net/
> > 
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel