[vlc-devel] [PATCH] qt: don't set the interface on top if the video will not be embedded
Rémi Denis-Courmont
remi at remlab.net
Tue Apr 2 13:13:08 CEST 2019
Can't we set the Qt UI on top only when the Qt vout window gets the flag set via set_state callback? I don't understand why you need to elaborate on top of the existing hack instead of just removing it.
Le 2 avril 2019 13:45:52 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 4/2/2019 10:40 AM, Rémi Denis-Courmont wrote:
>> I don't really see how you can enforce embedded video on Windows or
>> any Qt-based platform. You still have the headless (e.g. HTTP
>> interface, VLM, RC), Skin engine and multiple track scenarii that
>> cannot use the embedded Qt window provider.
>
>I agree. The proper vout_window_t for "non-embedded" for Windows is
>coming very soon (probably today).
>
>The problem is that if you start VLC with --no-embedded-video and
>--video-on-top you might end up having the Qt interface on top of the
>video and that should not be the case (I suppose the same issue exists
>on other OSes already).
>
>>
>> But that's beside the point: there are no reasons so far to make a
>> hack when a proper interface already exists.
>>
>> Le 2 avril 2019 09:19:57 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a
>
>> écrit :
>>
>> On 4/1/2019 5:26 PM, Rémi Denis-Courmont wrote:
>>
>> Le maanantaina 1. huhtikuuta 2019, 13.41.22 EEST Steve Lhomme
>> a écrit :
>>
>> The doc of video-on-top is:
>> Alwaysplacethevideowindowontopofotherwindows. That sounds
>> like a feature of the standalone video window rather than
>> the UI. It corresponds to the VOUT_WINDOW_STATE_ABOVE
>> state that is already handled by many of them. The UI may
>> use the flag if a standalone window is not used. But if
>> there is one, IMO it shouldn't.
>>
>> Yes, that seems to match the documentation. Still, I think Qt
>> should allow the window state, rather than second guess from
>> the configuration leading to unnecessary error corner cases.
>>
>>
>> It still does after this patch but only if we know we won't use
>an
>> external window (which is coming for Windows).
>>
>------------------------------------------------------------------------
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>> --
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>> excuser ma brièveté.
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel
--
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190402/09e5d8b8/attachment.html>
More information about the vlc-devel
mailing list