[vlc-devel] [PATCH] Fixed cover art operations not making "Save Metadata" button visible

[Tristan Matthews]

Hi,

On Tue, Apr 2, 2019 at 8:53 AM Abel Tesfaye <abeltesfaye45 at gmail.com> wrote:
>
> Fixed a bug located here https://trac.videolan.org/vlc/ticket/22107
>
> The following is the description of the bug:
>
> The "Save Metadata" button is not visible when cover art is changed using the "Add cover art from file" right-click menu.
> ---
>  modules/gui/qt/components/info_panels.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/gui/qt/components/info_panels.cpp b/modules/gui/qt/components/info_panels.cpp
> index 89182c5..d446e1a 100644
> --- a/modules/gui/qt/components/info_panels.cpp
> +++ b/modules/gui/qt/components/info_panels.cpp
> @@ -172,7 +172,7 @@ MetaPanel::MetaPanel( QWidget *parent,
>      CONNECT( seqtot_text, textEdited( QString ), this, enterEditMode() );
>
>      CONNECT( date_text, textEdited( QString ), this, enterEditMode() );
> -//    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );
> +    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );

Apparently this was commented out as it was breaking metadata updates:

commit 28085c7628a880a6584b89709c2d8c3f2a51b748
Author: Jean-Baptiste Kempf <jb at videolan.org>
Date:   Fri Jan 25 16:46:16 2013 +0100

    Qt: unbreak the update of metadata

Is this not still the case?

Best,
-t