[vlc-devel] [PATCH 2/3] player: add a QT window context

[Thomas Guillem]

On Tue, Apr 2, 2019, at 17:37, Rémi Denis-Courmont wrote:
> Le tiistaina 2. huhtikuuta 2019, 10.17.55 EEST Thomas Guillem a écrit :
> > I didn't see the answer in "[vlc-devel] [PATCH 1/3] player: add "vout
> > window" context getter/setter"
> > 
> > So I guess Rémi prefer to make the vlc_player_t a vlc_object.
> 
> Not particularly, no. There are certainly cleaner and uninvasive solutions to 
> replace the qt4-iface variable.

I don't see any other solutions for now (VLC 4.0).

> 
> The use of the window variable is a hack to avoid loading Qt in LibVLC apps - 
> which is not only very slow, but actually causes conflicts in some.

The same hacks are needed for hwnd/android/nsobject/X11Id too.

These context need to be setup in the vlc_player or libvlc_media_player, and we need a way to get it from "vout window" modules.

The 4th solution I see:
A different implementation of vlc_player_SetWindowContext, that will propagate the context to the "vout window" Open function via input resource and vout_Create calls.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel