[vlc-devel] [vlc-commits] crystalhd: use WCHAR were TEXT() was used to set the variable

[Jean-Baptiste Kempf]

>From the definition on MSDN:
https://docs.microsoft.com/en-us/windows/desktop/api/winnt/nf-winnt-text

Identifies a string as Unicode when UNICODE is defined by a preprocessor directive during compilation. Otherwise, the macro identifies a string as an ANSI string.

This is incorrect. 

See also
https://docs.microsoft.com/en-us/windows/desktop/learnwin32/working-with-strings

On Wed, 3 Apr 2019, at 09:56, Steve Lhomme wrote:
> vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Wed Apr  3 
> 08:51:06 2019 +0200| [cf73d45de451d0665dd7857c891a7d2f3e636dbd] | 
> committer: Steve Lhomme
> 
> crystalhd: use WCHAR were TEXT() was used to set the variable
> 
> _T() is for TCHAR, TEXT() is for WCHAR
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cf73d45de451d0665dd7857c891a7d2f3e636dbd
> ---
> 
>  modules/codec/crystalhd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/codec/crystalhd.c b/modules/codec/crystalhd.c
> index 5fab036989..98526e175c 100644
> --- a/modules/codec/crystalhd.c
> +++ b/modules/codec/crystalhd.c
> @@ -193,7 +193,7 @@ static int OpenDecoder( vlc_object_t *p_this )
>  #ifdef USE_DL_OPENING
>  #  define DLL_NAME "bcmDIL.dll"
>  #  define PATHS_NB 3
> -    static const TCHAR *psz_paths[PATHS_NB] = {
> +    static const WCHAR *psz_paths[PATHS_NB] = {
>          TEXT(DLL_NAME),
>          TEXT("C:\\Program Files\\Broadcom\\Broadcom CrystalHD 
> Decoder\\" DLL_NAME),
>          TEXT("C:\\Program Files (x86)\\Broadcom\\Broadcom CrystalHD 
> Decoder\\" DLL_NAME),
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734