[vlc-devel] [vlc-commits] qt: use WCHAR instead of TCHAR

Steve Lhomme robux4 at ycbcr.xyz
Wed Apr 3 15:31:09 CEST 2019


On 4/3/2019 1:57 PM, Jean-Baptiste Kempf wrote:
>
> On Wed, 3 Apr 2019, at 13:53, Steve Lhomme wrote:
>> On 4/3/2019 1:25 PM, Jean-Baptiste Kempf wrote:
>>> Again, this is wrong.
>> No, UNICODE is set so we always use the wide char API. Also see the
>> FromWide() that follows. Without UNICODE this would be totally wrong. So
>> at least it's coherent with the API it's using.
> No. If it was, the function should be the one with W

That's (part of) what UNICODE does. It adds the suffix so you don't have 
to. Are you suggesting we should remove the define and add the suffix 
ourself ? Or add support for non-UNICODE builds (which has been broken 
in many places for many years) ?


More information about the vlc-devel mailing list