[vlc-devel] [patch] Adding AMT module as a network access source. AMT allows IP multicast streams to be tunnelled over a non-multicast enabled network

Tristan Matthews tmatth at videolan.org
Fri Apr 5 17:13:31 CEST 2019

On Fri, Apr 5, 2019 at 11:03 AM Wayne Brassem <wbrassem at rogers.com> wrote:
> I’ve checked the code over and can’t see how any of the referenced sys->srcAddr statements below gets leaked.  This buffer is freed in Close(), but is in use until then.
> What am I missing?  I don’t want to resubmit if it’s still wrong.

In the previous patch submission, you were overwriting sys->srcAddr
with a strcpy without freeing it first.
The patch you just sent does not have this issue.

I'll take a closer look at the latest patch soon.


More information about the vlc-devel mailing list