[vlc-devel] [PATCH 1/3] Add uchardet library v0.0.6

[Konstantin Pavlov]

On Sun, Apr 07, 2019 at 09:38:24PM +0300, pertuleha at gmail.com wrote:
> From: Aleksei Pertu <pertuleha at gmail.com>
> 
> ---
>  configure.ac                    | 10 ++++++++++
>  contrib/src/uchardet/SHA512SUMS |  1 +
>  contrib/src/uchardet/rules.mak  | 25 +++++++++++++++++++++++++
>  3 files changed, 36 insertions(+)
>  create mode 100644 contrib/src/uchardet/SHA512SUMS
>  create mode 100644 contrib/src/uchardet/rules.mak
> 
> diff --git a/configure.ac b/configure.ac
> index 76971c6e0a..bfd1010636 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3991,6 +3991,16 @@ AS_IF([test "${enable_skins2}" = "yes" && test "${enable_libtar}" != "no"], [
>    ])
>  ])
>  
> +dnl
> +dnl  uchardet library for character encoding detection
> +dnl
> +AC_CHECK_HEADER([uchardet/uchardet.h], [ have_uchardet=yes ], [ have_uchardet=no ])
> +AM_CONDITIONAL([HAVE_UCHARDET], [ test "${have_uchardet}" = "yes" ])
> +if test "${have_uchardet}" = "yes"
> +then
> + VLC_ADD_LIBS([uchardet], [-luchardet -lstdc++])
> +fi
> +
>  dnl

Please use PKG_CHECK_MODULES here and use the Libs. from the pc file to
populate VLC_ADD_LIBS.

-- 
VideoLAN, Vice President
www.videolan.org
+7 926 165 45 31
@cryothresh