[vlc-devel] [PATCH] contrib: Make --disable-foo disable any package that depends on foo

[Rémi Denis-Courmont]

I don't agree with that. This works as intended currently.

If package is provided by OS, disabling it should not affect reverse dependencies IMO. And if it's not, it's debatable that silently disabling things is desirable.

Le 15 avril 2019 13:29:59 GMT+03:00, "Martin Storsjö" <martin at martin.st> a écrit :
>---
> contrib/src/main.mak | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>index 30a5e1f03a..b00534849a 100644
>--- a/contrib/src/main.mak
>+++ b/contrib/src/main.mak
>@@ -437,6 +437,8 @@ PKGS_AUTOMATIC := $(filter-out
>$(PKGS_FOUND),$(PKGS))
> # Apply manual selection (from bootstrap):
>PKGS_MANUAL := $(sort $(PKGS_ENABLE) $(filter-out
>$(PKGS_DISABLE),$(PKGS_AUTOMATIC)))
> # Resolve dependencies:
>+PKGS_DISABLE_TRANSITIVE := $(sort $(foreach p,$(PKGS_MANUAL),$(if
>$(filter $(PKGS_DISABLE),$(DEPS_$(p))),$(p))))
>+PKGS_MANUAL := $(filter-out $(PKGS_DISABLE_TRANSITIVE),$(PKGS_MANUAL))
>PKGS_DEPS := $(filter-out $(PKGS_FOUND) $(PKGS_MANUAL),$(sort $(foreach
>p,$(PKGS_MANUAL),$(DEPS_$(p)))))
> PKGS := $(sort $(PKGS_MANUAL) $(PKGS_DEPS))
> 
>@@ -495,6 +497,8 @@ list:
> 	@echo '  $(PKGS_AUTOMATIC)' | tr " " "\n" | sort | tr "\n" " " |fmt
> 	@echo Manually deselected packages:
> 	@echo '  $(PKGS_DISABLE)' | tr " " "\n" | sort | tr "\n" " " |fmt
>+	@echo Transitively deselected packages:
>+	@echo '  $(PKGS_DISABLE_TRANSITIVE)' | tr " " "\n" | sort | tr "\n" "
>" |fmt
> 	@echo Manually selected packages:
> 	@echo '  $(PKGS_ENABLE)' | tr " " "\n" | sort | tr "\n" " " |fmt
> 	@echo Depended-on packages:
>-- 
>2.17.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190415/e4832124/attachment.html>