[vlc-devel] [PATCH 06/13] macos: remove setVideoFilterChain

Thomas Guillem thomas at gllm.fr
Mon Apr 15 15:50:51 CEST 2019


It must be replaced with legacy vout variables handling.
---
 modules/gui/macosx/playlist/VLCPlayerController.h | 8 --------
 modules/gui/macosx/playlist/VLCPlayerController.m | 5 -----
 2 files changed, 13 deletions(-)

diff --git a/modules/gui/macosx/playlist/VLCPlayerController.h b/modules/gui/macosx/playlist/VLCPlayerController.h
index ea06f81482..534e1ed6f1 100644
--- a/modules/gui/macosx/playlist/VLCPlayerController.h
+++ b/modules/gui/macosx/playlist/VLCPlayerController.h
@@ -795,14 +795,6 @@ extern NSString *VLCPlayerMuteChanged;
  */
 - (nullable NSString *)videoFilterChainForType:(enum vlc_vout_filter_type)filterType;
 
-/**
- * sets the filter chain string for the respective type
- * @param the filter chain string or NULL to disable all filters
- * @param the filter type, @see vlc_vout_filter_type
- * @note This is a temporary API and will be gone in VLC 5.0
- */
-- (void)setVideoFilterChain:(nullable NSString *)filterChain forType:(enum vlc_vout_filter_type)filterType;
-
 /**
  * defines whether the vout windows lock on the video's AR or can be resized arbitrarily
  */
diff --git a/modules/gui/macosx/playlist/VLCPlayerController.m b/modules/gui/macosx/playlist/VLCPlayerController.m
index 9ad93370b1..cbb1f8c6eb 100644
--- a/modules/gui/macosx/playlist/VLCPlayerController.m
+++ b/modules/gui/macosx/playlist/VLCPlayerController.m
@@ -1620,11 +1620,6 @@ static const struct vlc_player_aout_cbs player_aout_callbacks = {
     return ret;
 }
 
-- (void)setVideoFilterChain:(NSString *)filterChain forType:(enum vlc_vout_filter_type)filterType
-{
-    vlc_player_vout_SetFilter(_p_player, filterType, filterChain != nil ? [filterChain UTF8String] : NULL);
-}
-
 - (void)setAspectRatioIsLocked:(BOOL)b_value
 {
     config_PutInt("macosx-lock-aspect-ratio", b_value);
-- 
2.20.1



More information about the vlc-devel mailing list