[vlc-devel] [PATCH V2 00/19] vout life cycle

Thomas Guillem thomas at gllm.fr
Tue Apr 16 16:25:10 CEST 2019


This new set invalidate the first patch set of 13 patches.

In the first patch set, the vout was created when the player was created.
However, the player is created from the playlist before the load of the first
interface. So, this was impossible for the vout to use a context from the
interface (qt or macos).

To fix this issue, the vout is now created on the first vlc_player_vout_Hold*()
call (if a video decoder didn't created it first). This allow macos and qt
interface to setup vout variables, that can take effect for the next playback.
(like it's done with the main aout).

Thomas Guillem (17):
  vout: don't call window operation when disabled
  resource: remove intermediate functions
  resource: merge both locks
  resource: reduce lock scope when starting the vout
  resource: add input_resource_HoldVoutLocked
  resource: always return a valid vout from HoldVout*()
  resource: don't allow to terminate vouts
  player: document vout lifecycle
  player: remove vlc_player_vout_SetFilter
  player: remove vlc_player_SetVideoSplitter
  player: change vout events
  hotkeys: re-indent after last commit
  test: player: test outputs
  qt: PlayerController: simplify getVout()
  qt: setup filter variables on the main vout
  macosx: setup effect variables on the main aout
  macosx: setup filter variables on the main vout

 include/vlc_input.h                           |   5 -
 include/vlc_player.h                          |  85 ++-----
 modules/control/gestures.c                    |  20 +-
 modules/control/hotkeys.c                     |  42 ++--
 .../coreinteraction/VLCVideoFilterHelper.m    |  76 ++----
 .../panels/VLCAudioEffectsWindowController.m  | 225 +++++++-----------
 .../panels/VLCVideoEffectsWindowController.m  | 151 ++++++------
 .../gui/macosx/playlist/VLCPlayerController.h |  14 --
 .../gui/macosx/playlist/VLCPlayerController.m |  26 +-
 modules/gui/qt/components/extended_panels.cpp |  43 +---
 .../gui/qt/components/player_controller.cpp   |  16 +-
 src/input/es_out.c                            |  26 --
 src/input/input.c                             |   1 -
 src/input/input_interface.h                   |   7 -
 src/input/player.c                            |  73 +-----
 src/input/resource.c                          | 198 +++++++--------
 src/input/vlm.c                               |   1 -
 src/libvlccore.sym                            |   4 -
 src/playlist_legacy/thread.c                  |   8 -
 src/video_output/video_output.c               |  49 +++-
 test/src/input/player.c                       |  71 +++++-
 21 files changed, 469 insertions(+), 672 deletions(-)

-- 
2.20.1



More information about the vlc-devel mailing list