[vlc-devel] [PATCH V2 10/17] player: remove vlc_player_SetVideoSplitter

[Thomas Guillem]

It must be replaced with legacy vout variables handling.
---
 include/vlc_player.h |  9 ---------
 src/input/player.c   | 26 --------------------------
 src/libvlccore.sym   |  1 -
 3 files changed, 36 deletions(-)

diff --git a/include/vlc_player.h b/include/vlc_player.h
index df96854685..72da5d78f0 100644
--- a/include/vlc_player.h
+++ b/include/vlc_player.h
@@ -2441,15 +2441,6 @@ vlc_player_SetPauseOnCork(vlc_player_t *player, bool enabled);
 VLC_API vlc_object_t *
 vlc_player_GetV4l2Object(vlc_player_t *player) VLC_DEPRECATED;
 
-/**
- * Set a video splitter to the main vout
- *
- * @param player locked instance
- * @param splitter a video splitter name or NULL
- */
-VLC_API void
-vlc_player_SetVideoSplitter(vlc_player_t *player, const char *splitter);
-
 /**
  * Get the audio output
  *
diff --git a/src/input/player.c b/src/input/player.c
index 6aa7be9872..1879197fd7 100644
--- a/src/input/player.c
+++ b/src/input/player.c
@@ -3329,30 +3329,6 @@ vlc_player_GetV4l2Object(vlc_player_t *player)
            (vlc_object_t*) input->thread : NULL;
 }
 
-void
-vlc_player_SetVideoSplitter(vlc_player_t *player, const char *splitter)
-{
-    if (config_GetType("video-splitter") == 0)
-        return;
-    struct vlc_player_input *input = vlc_player_get_input_locked(player);
-    if (!input)
-        return;
-
-    vout_thread_t *vout = vlc_player_vout_Hold(player);
-    var_SetString(vout, "video-splitter", splitter);
-    vout_Release(vout);
-
-    /* FIXME vout cannot handle live video splitter change, restart the main
-     * vout manually by restarting the first video es */
-    struct vlc_player_track *track;
-    vlc_vector_foreach(track, &input->video_track_vector)
-        if (track->selected)
-        {
-            vlc_player_RestartTrack(player, track->es_id);
-            break;
-        }
-}
-
 void
 vlc_player_vout_SetFullscreen(vlc_player_t *player, bool enabled)
 {
@@ -3488,8 +3464,6 @@ vlc_player_New(vlc_object_t *parent,
     VAR_CREATE("demux-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT);
 
     /* vout variables */
-    if (config_GetType("video-splitter"))
-        VAR_CREATE("video-splitter", VLC_VAR_STRING | VLC_VAR_DOINHERIT);
     VAR_CREATE("fullscreen", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
     VAR_CREATE("video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
     VAR_CREATE("video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
diff --git a/src/libvlccore.sym b/src/libvlccore.sym
index bb7f3ffd86..fc09ce6c37 100644
--- a/src/libvlccore.sym
+++ b/src/libvlccore.sym
@@ -910,7 +910,6 @@ vlc_player_SetSubtitleTextScale
 vlc_player_SetTeletextEnabled
 vlc_player_SetTeletextTransparency
 vlc_player_SetTrackCategoryEnabled
-vlc_player_SetVideoSplitter
 vlc_player_Start
 vlc_player_Stop
 vlc_player_title_list_GetAt
-- 
2.20.1