[vlc-devel] [PATCH 0/2] DBus: Correct introspection metadata

FeRD (Frank Dana) ferdnyc at gmail.com
Tue Apr 23 05:20:36 CEST 2019

DBus: Correct introspection metadata

The DBus introspection metadata contained several inconsistencies
with the MPRIS 2.2 specification: incorrectly-declared types,
readonly properties advertised read/write, and unadvertised signals
and properties. In all cases these were implemented correctly,
it was merely the metadata which was out of sync with the code.

This change corrects all of these discrepancies. It also rearranges
the elements in the introspection XML to match the order they're
listed in the MPRIS2 spec. The XML in VLC's source tree appeared to
have been alphabetized at some point in the past, but was no longer
in correct alphabetical order. Sorting the elements to match the spec
facilitated reconciling them.

Changes built on Fedora 29 and tested using D-Feet.

FeRD (Frank Dana) (2):
  dbus: Reorder introspection to match spec
  dbus: Correct introspection data

 modules/control/dbus/dbus_introspect.h | 45 ++++++++++++++------------
 1 file changed, 25 insertions(+), 20 deletions(-)


More information about the vlc-devel mailing list