[vlc-devel] [PATCH 0/2] DBus: Correct introspection metadata
thomas at gllm.fr
Wed Apr 24 09:54:26 CEST 2019
Thanks for your patches.
Tested on debian testing with mpris gnome extension.
They will be merged as soon as the vlc.git is reopened.
On Tue, Apr 23, 2019, at 10:13, FeRD (Frank Dana) wrote:
> DBus: Correct introspection metadata
> The DBus introspection metadata contained several inconsistencies
> with the MPRIS 2.2 specification: incorrectly-declared types,
> readonly properties advertised read/write, and unadvertised signals
> and properties. In all cases these were implemented correctly,
> it was merely the metadata which was out of sync with the code.
> This change corrects all of these discrepancies. It also rearranges
> the elements in the introspection XML to match the order they're
> listed in the MPRIS2 spec. The XML in VLC's source tree appeared to
> have been alphabetized at some point in the past, but was no longer
> in correct alphabetical order. Sorting the elements to match the spec
> facilitated reconciling them.
> Changes built on Fedora 29 and tested using D-Feet.
> FeRD (Frank Dana) (2):
> dbus: Reorder introspection to match spec
> dbus: Correct introspection data
> modules/control/dbus/dbus_introspect.h | 45 ++++++++++++++------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel