[vlc-devel] [PATCH 00/17] RFC Split block_t into 2 different data containers

[Denis Charmet]

Hi again,

On 2019-04-24 15:57, Thomas Guillem wrote:
>  - Code duplication between data.c and frame.c and also between
> data_helper.h and frame_helper.h: This code is far from trivial and
> should not be duplicated. We don't want to fix 2 files each time we
> need to fix a bug. The only way I see to solve this issue is to
> include vlc_data_t from vlc_frame_t and have generic vlc_data_t
> functions working with vlc_frame_t.

I'm very wary about downcasts and their missuse especially when using 
demux_chained.

I just thought of something that might help a huge deal for the helpers 
duplication:
We could push the bitstream reader APIs inside the stream.

Regards,
-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre