[vlc-devel] [PATCH] qml: Add settings button to player topbar

[Jean-Baptiste Kempf]

Disagree for both places.

On Fri, Aug 2, 2019, at 20:54, Rohan Rajpal wrote:
> I discussed it with Pierre before adding it. Adding the settings button would make it easy to access the settings and it will look consistent with the media library. 
> 
> On Sat, Aug 3, 2019, 12:03 AM Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> No. Why?
>> 
>>  On Fri, Aug 2, 2019, at 20:18, Rohan Rajpal wrote:
>>  > Add the settings button to player topbar.
>>  > ---
>>  > modules/gui/qt/qml/player/TopBar.qml | 22 +++++++++++++++++++++-
>>  > 1 file changed, 21 insertions(+), 1 deletion(-)
>>  > 
>>  > diff --git a/modules/gui/qt/qml/player/TopBar.qml 
>>  > b/modules/gui/qt/qml/player/TopBar.qml
>>  > index 365993dae3..7cae11e0bb 100644
>>  > --- a/modules/gui/qt/qml/player/TopBar.qml
>>  > +++ b/modules/gui/qt/qml/player/TopBar.qml
>>  > @@ -23,6 +23,7 @@ import org.videolan.vlc 0.1
>>  > 
>>  > import "qrc:///style/"
>>  > import "qrc:///utils/" as Utils
>>  > +import "qrc:///menus/" as Menus
>>  > 
>>  > Utils.NavigableFocusScope{
>>  > id: topFocusScope
>>  > @@ -77,8 +78,27 @@ Utils.NavigableFocusScope{
>>  > playlistWidget.gainFocus(playlistBtn)
>>  > }
>>  > }
>>  > - property bool acceptFocus: true
>>  > + KeyNavigation.right: menuBtn
>>  > }
>>  > +
>>  > + Utils.IconToolButton {
>>  > + id: menuBtn
>>  > + size: VLCStyle.icon_normal
>>  > + text: VLCIcons.menu
>>  > + onClicked: {
>>  > + lockAutoHide = true
>>  > + mainMenu.openBelow(this)
>>  > + }
>>  > + property alias mainMenuExt: mainMenu
>>  > + Menus.MainDropdownMenu {
>>  > + id: mainMenu
>>  > + onClosed: {
>>  > + lockAutoHide = false
>>  > + menuBtn.forceActiveFocus()
>>  > + }
>>  > + }
>>  > + }
>>  > +
>>  > }
>>  > }
>>  > }
>>  > -- 
>>  > 2.17.1
>>  > 
>>  > _______________________________________________
>>  > vlc-devel mailing list
>>  > To unsubscribe or modify your subscription options:
>>  > https://mailman.videolan.org/listinfo/vlc-devel
>> 
>>  -- 
>>  Jean-Baptiste Kempf - President
>>  +33 672 704 734
>>  _______________________________________________
>>  vlc-devel mailing list
>>  To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

--
Jean-Baptiste Kempf - President
+33 672 704 734


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190802/cb74ae88/attachment.html>