[vlc-devel] [PATCH] chromecast: transcode audio to MP3 320 kbps instead of 96 kbps

[Steve Lhomme]

LGTM

On 2019-08-08 21:33, ValdikSS via vlc-devel wrote:
> 
> Subject:
> [PATCH] chromecast: transcode audio to MP3 320 kbps instead of 96 kbps
> From:
> ValdikSS <iam at valdikss.org.ru>
> Date:
> 2019-08-08, 21:33
> To:
> vlc-devel at videolan.org
> 
> To:
> vlc-devel at videolan.org
> 
> 
> Chromecast transcoding code uses either Vorbis or MP3 for audio.
> For Vorbis, quality=4 is used, but for MP3 no bitrate or quality
> setting is set, which leads to default 96 kbps poor quality audio.
> 
> This patch explicitly sets 320 kbps bitrate for MP3, for much
> better audio quality.
> 
> Tested on Chromecast 3.
> ---
>   modules/stream_out/chromecast/cast.cpp | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/modules/stream_out/chromecast/cast.cpp b/modules/stream_out/chromecast/cast.cpp
> index c435f8ae69..9f909a9de1 100644
> --- a/modules/stream_out/chromecast/cast.cpp
> +++ b/modules/stream_out/chromecast/cast.cpp
> @@ -924,6 +924,8 @@ sout_stream_sys_t::GetAcodecOption( sout_stream_t *p_stream, vlc_fourcc_t *p_cod
>        * devices (Chromecast 1 & 2) */
>       if( *p_codec_audio == VLC_CODEC_VORBIS )
>           ssout << "aenc=vorbis{quality=4},";
> +    else if( *p_codec_audio == VLC_CODEC_MP3 )
> +        ssout << "ab=320,";
>       return ssout.str();
>   }
>   
> -- 
> 2.21.0
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>