[vlc-devel] [PATCH 0/3] [RFC] Add a control to get HTTP headers

Marvin Scholz epirat07 at gmail.com
Mon Aug 12 14:23:16 CEST 2019


On 12 Aug 2019, at 13:59, Rémi Denis-Courmont wrote:

> Hi,
>
> It won't work for Icy because the metadata is only initially in the 
> header, but updates are muxed in-band. Icy really is *not* HTTP and as 
> such it needs a custom access anyway.

Sorry if my goal was a bit unclear here. The Icy stream filter will 
parse the icy data in the stream,
but for that it needs the initial Icy-Metaint header value.

Note that I am not talking about the Icy Protocol, which is a HTTP-like 
protocol currently handled
by the old http access. This has nothing to do with the Icy metadata 
stuff, it is a proprietary
thing SHOUTcast did and I think even they stop doing that in recent 
versions in favor of HTTP.

So yes, for the ICY protocol it would need a special access module in 
the future if we plan to get
rid of the oldhttp one.

>
> Le 12 août 2019 12:56:05 GMT+03:00, Marvin Scholz 
> <epirat07 at gmail.com> a écrit :
>> This patchset adds a new Control, STREAM_GET_HTTP_HEADER, to
>> fetch HTTP headers and implements it for the new and old http
>> module.
>>
>> The idea, if this is accepted, is to use this for an ICY metadata
>> stream filter module to get the Icy-Metaint header and other ICY
>> specific metadata headers.
>>
>> Additionally it might be useful for some lua script modules to be
>> able to access the http headers of a stream.
>>
>> Marvin Scholz (3):
>>  libvlccore: Add STREAM_GET_HTTP_HEADER control
>>  access/oldhttp: Implement STREAM_GET_HTTP_HEADER
>>  access/http: Implement STREAM_GET_HTTP_HEADER
>>
>> include/vlc_stream.h           |  1 +
>> modules/access/http.c          | 73 
>> ++++++++++++++++++++++++++++++++++
>> modules/access/http/access.c   |  7 ++++
>> modules/access/http/file.h     |  1 +
>> modules/access/http/live.h     |  1 +
>> modules/access/http/resource.c | 10 +++++
>> modules/access/http/resource.h |  7 ++++
>> 7 files changed, 100 insertions(+)
>>
>> -- 
>> 2.19.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté._______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list