[vlc-devel] [PATCH 1/3] libvlccore: Add STREAM_GET_HTTP_HEADER control
Marvin Scholz
epirat07 at gmail.com
Mon Aug 12 14:26:27 CEST 2019
On 12 Aug 2019, at 14:00, Rémi Denis-Courmont wrote:
> This looks like horrible violation of abstraction and layering. We
> already have higher level getters for metadata.
>
I considered using metadata for this but there were some issues:
- How would you ensure HTTP headers never collide with other metadata
keys?
- How to handle that HTTP headers are case-insensitive? Just lowercase
them?
I am happy to rewrite this patchset using stream metadata instead if
thats considered a better approach.
> Le 12 août 2019 12:56:06 GMT+03:00, Marvin Scholz
> <epirat07 at gmail.com> a écrit :
>> ---
>> include/vlc_stream.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/vlc_stream.h b/include/vlc_stream.h
>> index bc6c0d30b7..1b6186baeb 100644
>> --- a/include/vlc_stream.h
>> +++ b/include/vlc_stream.h
>> @@ -168,6 +168,7 @@ enum stream_query_e
>> STREAM_GET_CONTENT_TYPE, /**< arg1= char ** res=can fail
>> */
>> STREAM_GET_SIGNAL, /**< arg1=double *pf_quality, arg2=double
>> *pf_strength res=can fail */
>> STREAM_GET_TAGS, /**< arg1=const block_t ** res=can fail
>> */
>> + STREAM_GET_HTTP_HEADER, /**< arg1=const char *header arg2=char
>> ** res=can fail */
>>
>> STREAM_SET_PAUSE_STATE = 0x200, /**< arg1= bool res=can fail
>> */
>> STREAM_SET_TITLE, /**< arg1= int res=can fail */
>> --
>> 2.19.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
> excuser ma brièveté._______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
More information about the vlc-devel
mailing list