[vlc-devel] [PATCH 1/3] libvlccore: Add STREAM_GET_HTTP_HEADER control

[Marvin Scholz]

On 12 Aug 2019, at 17:49, Rémi Denis-Courmont wrote:

> Le maanantaina 12. elokuuta 2019, 18.45.59 EEST Marvin Scholz a écrit :
>> On 12 Aug 2019, at 15:19, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> I think you're missing the point here. You can't just pass opaque data
>>> through filters, and you don't control what header lines get sent or
>>> when. This is the block flags discussion all over again. What you're
>>> doing just isn't a good fit with the stream abstraction.
>>
>> I don't see how this is related to block flags, this is stream level
>> metadata and the http headers do not change
>> mid-stream, do they?
>
> Sure they do.

Oh, how? My understanding is that they are sent at the beginning of the
response and do not change?

>
>>> Besides, how will this work if the HTTP access does not have a special
>>> case for sending the ICY header line in requests??
>>
>> Yes, of course the access modules would need to set a header to announce
>> that the application can handle ICY
>> metadata, there is no way around that.
>
> In other words, your so-called generic API fails the litmus test at being
> generic.
>

How is it not generic? You give the stream filter a stream with icy metadata
and the meta interval, it filters out the Icy metadata. That seems very
generic to me.

> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel