[vlc-devel] [vlc-commits] access: dvdread: fix inverted commands on boundary / data sequence

[Hugo Beauzée-Luyssen]

On Fri, Aug 16, 2019, at 8:38 PM, Francois Cartegnie wrote:
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Fri Aug 
> 16 19:29:04 2019 +0200| [89070a7c3ac76580b6a655078bc6f6b5e1342168] | 
> committer: Francois Cartegnie
> 
> access: dvdread: fix inverted commands on boundary / data sequence
> 
> fixes broken clock/clock jump and glitch on title change
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=89070a7c3ac76580b6a655078bc6f6b5e1342168
> ---
> 
>  modules/access/dvdread.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/modules/access/dvdread.c b/modules/access/dvdread.c
> index 7a36ac3830..b119a8f615 100644
> --- a/modules/access/dvdread.c
> +++ b/modules/access/dvdread.c
> @@ -478,6 +478,7 @@ static int Demux( demux_t *p_demux )
>          /* Basic check to be sure we don't have a empty title
>           * go to next title if so */
>          //assert( p_buffer[41] == 0xbf && p_buffer[1027] == 0xbf );
> +        DemuxBlock( p_demux, p_buffer, DVD_VIDEO_LB_LEN );
>  
>          /* Parse the contained dsi packet */
>          DvdReadHandleDSI( p_demux, p_buffer );
> @@ -503,12 +504,8 @@ static int Demux( demux_t *p_demux )
>              return 0; /* EOF */
>          }
>  
> -        /* FIXME: Ugly kludge: we send the pack block to the input for it
> -         * sometimes has a zero scr and restart the sync */
>          p_sys->i_cur_block++;
>          p_sys->i_title_offset++;
> -
> -        DemuxBlock( p_demux, p_buffer, DVD_VIDEO_LB_LEN );
>      }
>  
>      if( p_sys->i_cur_cell >= p_sys->p_cur_pgc->nr_of_cells )
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>

Should this and "fix invalid PCR on title start" be backported?

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr