[vlc-devel] [PATCH 08/13] player: add the timer API

Thomas Guillem thomas at gllm.fr
Thu Aug 22 17:50:28 CEST 2019


On Thu, Aug 22, 2019, at 17:43, Rémi Denis-Courmont wrote:
> Le torstaina 22. elokuuta 2019, 18.25.11 EEST Romain Vimont a écrit :
> > In that case, it should probably use the SOURCE timer, and use a local
> > thread to do stuff at the exact time it wants. (REGULAR is just an
> > helper for regular updates).
> 
> I don't see the use case for regular. By definition, API users will care about 
> the play time, not the wall clock. And if they really want a wall clock timer, 
> there is already a convenience API (vlc_timer).
> 
> IMO, this "regular" mode just makes the wrong thing easy (not to say 
> encouraged).

This regular mode should not be encouraged. Every main UI (android/macos/Qt) must use the Source timer.

In the future, there might be some control/interfaces modules that don't have a mainloop/timer/threads, so the regular mode could help. I'm thinking about lua/web plugins for example.


> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list