[vlc-devel] [PATCH 2/3] input: return a status from input_ControlPush

[Rémi Denis-Courmont]

Le maanantaina 26. elokuuta 2019, 18.28.26 EEST Thomas Guillem a écrit :
> On Mon, Aug 26, 2019, at 17:14, Rémi Denis-Courmont wrote:
> > Hello,
> > 
> > Most if not all controls can be reduced to constant size state because
> > they either cancel previous controls or accumulate. There are no reasons
> > why queueing them should be allowed to fail.
> > 
> > What control actually can fail to be requested?
> 
> Seeking from the macOS slider. It also need to be fixed in the UI in order
> to not spam seek requests.

No. Queueing a seek request cannot fail. Seeking can always be reduced to a 
constant size finite state, and AFAIR, Laurent already fixed that (in 
circumvoluted manner) a decade ago.
(That is not to say that seeking itself cannot fail, but that's asynchronous, 
so it cannot be a return value.)
We should really not bother UIs with errors that the core can avoid and which 
UIs have no reasonable ways to handle.

> But there are some controls that can't be reduced, like INPUT_CONTROL_NAV_*. 

Yeah, but typically UIs don't expect keyboard events to be discarded. They 
should really be rate-limited by blocking IMO.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/