[vlc-devel] [PATCH 2/3] libvlc: fix libvlc_video_set_mouse_input prototype

Alexandre Janniaux ajanni at videolabs.io
Mon Dec 2 15:28:52 CET 2019


Use booleans instead of unsigned when taking a boolean value.
---
 include/vlc/libvlc_media_player.h | 2 +-
 lib/video.c                       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
index 2a5dc57b22..f20decf028 100644
--- a/include/vlc/libvlc_media_player.h
+++ b/include/vlc/libvlc_media_player.h
@@ -1429,7 +1429,7 @@ void libvlc_video_set_key_input( libvlc_media_player_t *p_mi, bool on );
  * \param on true to handle mouse click events, false to ignore them.
  */
 LIBVLC_API
-void libvlc_video_set_mouse_input( libvlc_media_player_t *p_mi, unsigned on );
+void libvlc_video_set_mouse_input( libvlc_media_player_t *p_mi, bool on );
 
 /**
  * Get the pixel dimensions of a video.
diff --git a/lib/video.c b/lib/video.c
index dd6f514ffd..291869b391 100644
--- a/lib/video.c
+++ b/lib/video.c
@@ -122,9 +122,9 @@ void libvlc_video_set_key_input( libvlc_media_player_t *p_mi, bool on )
     var_SetBool (p_mi, "keyboard-events", on);
 }
 
-void libvlc_video_set_mouse_input( libvlc_media_player_t *p_mi, unsigned on )
+void libvlc_video_set_mouse_input( libvlc_media_player_t *p_mi, bool on )
 {
-    var_SetBool (p_mi, "mouse-events", !!on);
+    var_SetBool (p_mi, "mouse-events", on);
 }
 
 int
-- 
2.24.0



More information about the vlc-devel mailing list